Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read-functions for triple manager; removed unused comparator files #5879

Merged
merged 4 commits into from
Apr 5, 2024

Conversation

bowenxia
Copy link
Contributor

@bowenxia bowenxia commented Apr 5, 2024

What changed?
add read-functions for triple manager
removed unused comparator files because those are in mono repo now.

Why?
code coverage week

How did you test it?
unit test

Potential risks

Release notes

Documentation Changes

Copy link

codecov bot commented Apr 5, 2024

Codecov Report

Merging #5879 (4bace34) into master (b41175f) will increase coverage by 0.27%.
The diff coverage is n/a.

Additional details and impacted files

see 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b41175f...4bace34. Read the comment docs.

@coveralls
Copy link

coveralls commented Apr 5, 2024

Pull Request Test Coverage Report for Build 018eb046-0fc5-4fa0-9d12-d6dcb7cfbb9d

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 13 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.2%) to 66.803%

Files with Coverage Reduction New Missed Lines %
common/cache/lru.go 2 92.89%
service/history/queue/transfer_queue_processor.go 2 57.17%
service/matching/matcher.go 2 90.72%
service/matching/taskListManager.go 7 79.7%
Totals Coverage Status
Change from base Build 018eb042-ac3a-4dd1-b776-db1bed1cebdf: 0.2%
Covered Lines: 97518
Relevant Lines: 145979

💛 - Coveralls

@bowenxia bowenxia merged commit b28dca3 into master Apr 5, 2024
19 of 21 checks passed
@bowenxia bowenxia deleted the xbowen_pinot_triple_manager_test02 branch April 5, 2024 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants