Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: For handler: Register Domain in common/domain folder #5876

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

abhishekj720
Copy link
Contributor

What changed?
Added tests for registerDomain for handler in common/domain

Why?
As part of test coverage week.

How did you test it?
Unit Test

Potential risks
Tests are written to avoid risks

@coveralls
Copy link

Pull Request Test Coverage Report for Build 018eaf70-3bd4-4eb7-87ea-a2b88e9de6d6

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 38 unchanged lines in 11 files lost coverage.
  • Overall coverage increased (+0.007%) to 66.582%

Files with Coverage Reduction New Missed Lines %
common/task/weighted_round_robin_task_scheduler.go 2 89.05%
common/peerprovider/ringpopprovider/config.go 2 81.58%
common/task/fifo_task_scheduler.go 2 85.57%
service/history/task/transfer_active_task_executor.go 2 72.83%
common/util.go 2 91.78%
common/persistence/historyManager.go 2 66.67%
tools/cli/admin_db_decode_thrift.go 3 69.23%
service/history/queue/timer_gate.go 3 95.83%
service/history/task/fetcher.go 5 85.57%
service/history/execution/mutable_state_task_refresher.go 7 62.66%
Totals Coverage Status
Change from base Build 018eae75-8edb-4580-9ce6-f18a0f6bd028: 0.007%
Covered Lines: 97423
Relevant Lines: 146320

💛 - Coveralls

@abhishekj720 abhishekj720 enabled auto-merge (squash) April 5, 2024 18:30
suite.Run(t, new(HandlerSuite))
}

func (s *HandlerSuite) SetupTest() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

each table test should start fresh instead of reusing same handler. So I'd ditch the suite and make this a helper function to be called inside t.Run

@abhishekj720 abhishekj720 merged commit 2afe803 into uber:master Apr 5, 2024
18 checks passed
@abhishekj720 abhishekj720 deleted the testh branch April 5, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants