Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit tests for persistence task types in DataManagerInterfaces #5720

Merged
merged 6 commits into from
Mar 5, 2024
Merged

Add unit tests for persistence task types in DataManagerInterfaces #5720

merged 6 commits into from
Mar 5, 2024

Conversation

timl3136
Copy link
Contributor

@timl3136 timl3136 commented Mar 5, 2024

What changed?
Add unit tests for some task types used by persistence and some other functions

Why?
Improve unit test coverage and stability of the platform

How did you test it?
unit test

Potential risks

Release notes

Documentation Changes

@coveralls
Copy link

coveralls commented Mar 5, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 018e108f-1968-4972-bd59-e33171519d6b

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 11 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.1%) to 63.258%
Files with Coverage Reduction New Missed Lines %
service/history/task/transfer_standby_task_executor.go 2 87.84%
service/matching/taskListManager.go 2 80.46%
common/task/fifo_task_scheduler.go 3 80.41%
service/history/task/fetcher.go 4 85.05%
Totals Coverage Status
Change from base Build 018e1087-e1f8-45d1-ab16-a78acfeffad8: 0.1%
Covered Lines: 92777
Relevant Lines: 146665
💛 - Coveralls

@timl3136 timl3136 enabled auto-merge (squash) March 5, 2024 20:33
@timl3136 timl3136 merged commit 50b4b84 into uber:master Mar 5, 2024
18 checks passed
ketsiambaku pushed a commit to ketsiambaku/cadence that referenced this pull request Mar 6, 2024
@timl3136 @ketsiambaku
Add unit tests for persistence task types in DataManagerInterfaces, a…
61a933e 
…lso renamed DataManagerInterfaces to data-manager-interfaces (uber#5720)

* Add Unit tests for persistence Task types

* Renamed DataManagerInterfaces to data-manager-interfaces
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taylanisikdemir taylanisikdemir taylanisikdemir approved these changes

@Shaddoll Shaddoll Awaiting requested review from Shaddoll Shaddoll is a code owner

@neil-xie neil-xie Awaiting requested review from neil-xie neil-xie is a code owner

@davidporter-id-au davidporter-id-au Awaiting requested review from davidporter-id-au davidporter-id-au is a code owner

@Groxx Groxx Awaiting requested review from Groxx Groxx is a code owner

@shijiesheng shijiesheng Awaiting requested review from shijiesheng shijiesheng is a code owner

@agautam478 agautam478 Awaiting requested review from agautam478

@jakobht jakobht Awaiting requested review from jakobht jakobht is a code owner

@3vilhamster 3vilhamster Awaiting requested review from 3vilhamster 3vilhamster is a code owner

@sankari165 sankari165 Awaiting requested review from sankari165 sankari165 is a code owner

@dkrotx dkrotx Awaiting requested review from dkrotx dkrotx is a code owner

@demirkayaender demirkayaender Awaiting requested review from demirkayaender demirkayaender is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@timl3136 @coveralls @taylanisikdemir @agautam478