Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial codecov integration #5711

Merged
merged 6 commits into from
Mar 5, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions .github/workflows/codecov.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
name: Workflow for Codecov integration
on: [push, pull_request]
jobs:
codecov:
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v4
with:
fetch-depth: 0

- name: Set up Go
uses: actions/setup-go@v4
with:
go-version: 1.22.x
cache: false

- name: Download dependencies
run: go mod download

- name: Test and generate coverage report
run: make cover_profile

- name: Upload coverage reports to Codecov
uses: codecov/[email protected] # https://github.com/codecov/codecov-action
with:
file: .build/coverage/unit_cover.out
exclude: ./
token: ${{ secrets.CODECOV_TOKEN }}
slug: uber/cadence
48 changes: 48 additions & 0 deletions codecov.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,48 @@
# Refs:
# - https://docs.codecov.com/docs/common-recipe-list
# - https://docs.codecov.com/docs/codecovyml-reference
#
# After making changes, run below command to validate
# curl --data-binary @codecov.yml https://codecov.io/validate
coverage:
range: 80...100
round: down
precision: 2
status:
project: # measuring the overall project coverage
default: # context, you can create multiple ones with custom titles
informational: true
target: 85% # specify the target coverage for each commit status
# option: "auto" (compare against parent commit or pull request base)
# option: "X%" a static target percentage to hit
threshold: 0% # allow the coverage drop by x% before marking as failure
if_ci_failed: ignore # require the CI to pass before setting the status
patch:
default:
informational: true
comment:
layout: "header, files, footer"
hide_project_coverage: false
codecov:
require_ci_to_pass: false
ignore:
- "**/*_generated.go"
- "**/*_mock.go"
- "**/*_test.go"
- "**/*_test_utils.go"
- "**/main.go"
- "**/mocks/**"
- "**/testing/**"
- "bench/**"
- "canary/**"
- "common/persistence/persistence-tests/**"
- "common/log/**"
- "common/metrics/**"
- "common/persistence/nosql/nosqlplugin/dynamodb/**"
- "common/persistence/nosql/nosqlplugin/mongodb/**"
- "common/types/shared.go" # 8k lines of getters. Not worth testing manually but consider switching to generated code.
- "common/types/testdata/**"
- "idls/**"
- "host/**"
- "testflags/**"
- "tools/linter/**"
3 changes: 3 additions & 0 deletions common/messaging/kafka/consumer_impl_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,9 @@ import (
)

func TestNewConsumer(t *testing.T) {
// TODO: remove skip after PR #5712 is merged
t.Skip()

mockProducer := mocks.NewSyncProducer(t, nil)
group := "tests"
mockBroker := initMockBroker(t, group)
Expand Down
Loading