Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ES: do not set _type when using Bulk API for v7 client #5104

Merged
merged 9 commits into from
Mar 10, 2023
15 changes: 14 additions & 1 deletion .buildkite/pipeline-pull-request.yml
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,20 @@ steps:
- docker-compose#v3.0.0:
run: integration-test-cassandra
config: docker/buildkite/docker-compose-es7.yml

- label: ":golang: integration test with cassandra with OpenSearch v2"
agents:
queue: "workers"
docker: "*"
command: "make cover_integration_profile"
artifact_paths:
- ".build/coverage/*.out"
retry:
automatic:
limit: 1
plugins:
- docker-compose#v3.0.0:
run: integration-test-cassandra
config: docker/buildkite/docker-compose-opensearch2.yml
- label: ":golang: integration ndc test with cassandra"
agents:
queue: "workers"
Expand Down
3 changes: 0 additions & 3 deletions common/elasticsearch/client_v7.go
Original file line number Diff line number Diff line change
Expand Up @@ -475,14 +475,12 @@ func (v *v7BulkProcessor) Add(request *GenericBulkableAddRequest) {
case BulkableDeleteRequest:
req = elastic.NewBulkDeleteRequest().
Index(request.Index).
Type(request.Type).
Id(request.ID).
VersionType(request.VersionType).
Version(request.Version)
case BulkableIndexRequest:
req = elastic.NewBulkIndexRequest().
Index(request.Index).
Type(request.Type).
Id(request.ID).
VersionType(request.VersionType).
Version(request.Version).
Expand All @@ -493,7 +491,6 @@ func (v *v7BulkProcessor) Add(request *GenericBulkableAddRequest) {
req = elastic.NewBulkIndexRequest().
OpType("create").
Index(request.Index).
Type(request.Type).
Id(request.ID).
VersionType("internal").
Doc(request.Doc)
Expand Down
71 changes: 71 additions & 0 deletions docker/buildkite/docker-compose-opensearch2.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,71 @@
version: "3.5"

services:
cassandra:
image: cassandra:3.11
networks:
services-network:
aliases:
- cassandra

zookeeper:
image: wurstmeister/zookeeper:3.4.6
networks:
services-network:
aliases:
- zookeeper

kafka:
image: wurstmeister/kafka:2.12-2.1.1
depends_on:
- zookeeper
networks:
services-network:
aliases:
- kafka
environment:
KAFKA_ADVERTISED_LISTENERS: PLAINTEXT://kafka:9092
KAFKA_LISTENERS: PLAINTEXT://0.0.0.0:9092
KAFKA_ZOOKEEPER_CONNECT: zookeeper:2181

elasticsearch:
image: opensearchproject/opensearch:2.5.0
networks:
services-network:
aliases:
- elasticsearch
environment:
- discovery.type=single-node
- plugins.security.disabled=true

integration-test-cassandra:
build:
context: ../../
dockerfile: ./docker/buildkite/Dockerfile
environment:
- "CASSANDRA=1"
- "CASSANDRA_SEEDS=cassandra"
- "ES_SEEDS=elasticsearch"
- "KAFKA_SEEDS=kafka"
- "TEST_TAG=esintegration"
- "ES_VERSION=v7"
- BUILDKITE_AGENT_ACCESS_TOKEN
- BUILDKITE_JOB_ID
- BUILDKITE_BUILD_ID
- BUILDKITE_BUILD_NUMBER
depends_on:
- cassandra
- elasticsearch
- kafka
volumes:
- ../../:/cadence
- /usr/bin/buildkite-agent:/usr/bin/buildkite-agent
networks:
services-network:
aliases:
- integration-test

networks:
services-network:
name: services-network
driver: bridge