Removed TaskID from types.HistoryTaskV2Attributes

[vytautas-karpavicius]

What changed?
Removed TaskID field from types.HistoryTaskV2Attributes

Why?
Not actually used anywhere. Instead we have another SourceTaskID field which is set on types.ReplicationTask that is actually used. It caught my attention as this was set to suspicious value in TaskAckManager:

    TaskID:              task.FirstEventID,

After checking, it looks like do not care about this field in the other side of replication stack.

How did you test it?
Existing tests.

Potential risks

Release notes

Documentation Changes

[coveralls]

Pull Request Test Coverage Report for Build 0181a407-18e2-405f-b988-fb295dcbf189

• 0 of 0 changed or added relevant lines in 0 files are covered.
• 70 unchanged lines in 14 files lost coverage.
• Overall coverage decreased (-0.04%) to 57.959%

---

Files with Coverage Reduction	New Missed Lines	%
common/persistence/nosql/nosqlplugin/cassandra/domain.go	1	66.09%
common/persistence/nosql/nosqlDomainStore.go	2	69.04%
common/task/weightedRoundRobinTaskScheduler.go	2	89.12%
service/matching/matcher.go	2	91.46%
common/persistence/nosql/nosqlplugin/cassandra/db.go	3	62.5%
service/history/task/task.go	3	77.06%
service/history/task/transfer_standby_task_executor.go	3	89.32%
service/history/task/fetcher.go	4	91.28%
common/cache/domainCache.go	5	88.48%
common/persistence/nosql/utils.go	5	0%

Totals
Change from base Build 01819355-fe3c-47c3-8fc2-a1bc91ddc928:	-0.04%
Covered Lines:	83912
Relevant Lines:	144778

---

💛 - Coveralls

[davidporter-id-au]

Is there a corresponding IDL change being made? I'm not super familiar with this type, sorry

[Groxx]

yeah, should probably be marked as deprecated at the very least.

and I assume(?) this is server-side only? or do we have to worry about old clients / old servers during an upgrade?

[vytautas-karpavicius]

yeah, should probably be marked as deprecated at the very least.

Yeah, good idea: uber/cadence-idl#113

and I assume(?) this is server-side only? or do we have to worry about old clients / old servers during an upgrade?

It is server side only. Specifically part of replication stack.