Merge branch 'master' into feature/msb-coverage-ii

uber · Oct 30, 2024 · ff1dc97 · ff1dc97
2 parents fc2bb19 + 21b40bd
commit ff1dc97
Show file tree

Hide file tree

Showing 148 changed files with 22,502 additions and 1,812 deletions.
diff --git a/common/cache/domainCache_test.go b/common/cache/domainCache_test.go
diff --git a/common/client/versionChecker.go b/common/client/versionChecker.go
@@ -18,6 +18,8 @@
 // OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
 // THE SOFTWARE.
 
+//go:generate mockgen -package $GOPACKAGE -destination versionChecker_mock.go -self_package github.com/uber/cadence/common/client github.com/uber/cadence/common/client VersionChecker
+
 package client
 
 import (

diff --git a/common/client/versionChecker_mock.go b/common/client/versionChecker_mock.go
diff --git a/common/codec/interface.go b/common/codec/interface.go
@@ -18,6 +18,8 @@
 // OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
 // THE SOFTWARE.
 
+//go:generate mockgen -package $GOPACKAGE -destination interfaces_mock.go -self_package github.com/uber/cadence/common/codec github.com/uber/cadence/common/codec BinaryEncoder
+
 package codec
 
 import (

diff --git a/common/codec/interfaces_mock.go b/common/codec/interfaces_mock.go
diff --git a/common/config/config.go b/common/config/config.go
@@ -182,6 +182,7 @@ type (
 		AdvancedVisibilityStore string `yaml:"advancedVisibilityStore"`
 		// HistoryMaxConns is the desired number of conns to history store. Value specified
 		// here overrides the MaxConns config specified as part of datastore
+		// Deprecated: This value is not used
 		HistoryMaxConns int `yaml:"historyMaxConns"`
 		// EnablePersistenceLatencyHistogramMetrics is to enable latency histogram metrics for persistence layer
 		EnablePersistenceLatencyHistogramMetrics bool `yaml:"enablePersistenceLatencyHistogramMetrics"`

diff --git a/common/dynamicconfig/constants.go b/common/dynamicconfig/constants.go
@@ -657,6 +657,7 @@ const (
 	// Value type: Int
 	// Default value: 10
 	// Allowed filters: N/A
+	// Deprecated: not used
 	FrontendHistoryMgrNumConns
 	// FrontendThrottledLogRPS is the rate limit on number of log messages emitted per second for throttled logger
 	// KeyName: frontend.throttledLogRPS
@@ -1064,12 +1065,14 @@ const (
 	// Value type: Int
 	// Default value: 50
 	// Allowed filters: N/A
+	// Deprecated: not used
 	ExecutionMgrNumConns
 	// HistoryMgrNumConns is persistence connections number for HistoryManager
 	// KeyName: history.historyMgrNumConns
 	// Value type: Int
 	// Default value: 50
 	// Allowed filters: N/A
+	// Deprecated: not used
 	HistoryMgrNumConns
 	// MaximumBufferedEventsBatch is max number of buffer event in mutable state
 	// KeyName: history.maximumBufferedEventsBatch
@@ -3130,7 +3133,7 @@ var IntKeys = map[IntKey]DynamicInt{
 	},
 	FrontendHistoryMgrNumConns: {
 		KeyName:      "frontend.historyMgrNumConns",
-		Description:  "FrontendHistoryMgrNumConns is for persistence cluster.NumConns",
+		Description:  "Deprecated: not used. FrontendHistoryMgrNumConns is for persistence cluster.NumConns",
 		DefaultValue: 10,
 	},
 	FrontendThrottledLogRPS: {
@@ -3479,12 +3482,12 @@ var IntKeys = map[IntKey]DynamicInt{
 	},
 	ExecutionMgrNumConns: {
 		KeyName:      "history.executionMgrNumConns",
-		Description:  "ExecutionMgrNumConns is persistence connections number for ExecutionManager",
+		Description:  "Deprecated: not used. ExecutionMgrNumConns is persistence connections number for ExecutionManager",
 		DefaultValue: 50,
 	},
 	HistoryMgrNumConns: {
 		KeyName:      "history.historyMgrNumConns",
-		Description:  "HistoryMgrNumConns is persistence connections number for HistoryManager",
+		Description:  "Deprecated: not used. HistoryMgrNumConns is persistence connections number for HistoryManager",
 		DefaultValue: 50,
 	},
 	MaximumBufferedEventsBatch: {

diff --git a/common/persistence/client/bean.go b/common/persistence/client/bean.go
@@ -370,6 +370,7 @@ func (s *BeanImpl) Close() {
 	s.shardManager.Close()
 	s.historyManager.Close()
 	s.executionManagerFactory.Close()
+	s.configStoreManager.Close()
 	for _, executionMgr := range s.shardIDToExecutionManager {
 		executionMgr.Close()
 	}