Skip to content

Commit

Permalink
User new dockerfiles (#2331)
Browse files Browse the repository at this point in the history
  • Loading branch information
longquanzheng authored and shreyassrivatsan committed Aug 6, 2019
1 parent e64142e commit a8fd5a6
Show file tree
Hide file tree
Showing 6 changed files with 13 additions and 9 deletions.
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ CMD dockerize -template /etc/cadence/config/config_template.yaml:/etc/cadence/co


# All-in-one Cadence server
FROM cadence-server AS cadence-allinone
FROM cadence-server AS cadence-auto-setup

RUN apk add --update --no-cache ca-certificates py-pip mysql-client
RUN pip install cqlsh
Expand Down
5 changes: 3 additions & 2 deletions docker/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,9 @@ Building an image for any branch and restarting
-----------------------------------------
Replace **YOUR_TAG** and **YOUR_CHECKOUT_BRANCH** in the below command to build:
```
cd $GOPATH/src/github.com/uber/cadence/docker
docker build . -t ubercadence/server:YOUR_TAG --build-arg git_branch=YOUR_CHECKOUT_BRANCH
cd $GOPATH/src/github.com/uber/cadence
git checkout YOUR_CHECKOUT_BRANCH
docker build . -t ubercadence/server:YOUR_TAG --build-arg TARGET=auto-setup
```
Replace the tag of **image: ubercadence/server** to **YOUR_TAG** in docker-compose.yml .
Then stop service and remove all containers using the below commands.
Expand Down
2 changes: 2 additions & 0 deletions docker/docker-compose-es.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,8 @@ services:
environment:
- discovery.type=single-node
cadence:
# TODO https://github.com/uber/cadence/issues/2330
# after fixing the ES container, need to use the new image: server:master-auto-setup
image: ubercadence/server-es:master
ports:
- "7933:7933"
Expand Down
2 changes: 1 addition & 1 deletion docker/docker-compose-mysql.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ services:
- "8125:8125"
- "8126:8126"
cadence:
image: ubercadence/server:0.6.0
image: ubercadence/server:master-auto-setup
ports:
- "7933:7933"
- "7934:7934"
Expand Down
2 changes: 1 addition & 1 deletion docker/docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ services:
- "8125:8125"
- "8126:8126"
cadence:
image: ubercadence/server:0.6.0
image: ubercadence/server:master-auto-setup
ports:
- "7933:7933"
- "7934:7934"
Expand Down
9 changes: 5 additions & 4 deletions scripts/buildkite/docker-push.sh
Original file line number Diff line number Diff line change
Expand Up @@ -17,12 +17,13 @@ if [ "$BUILDKITE_COMMIT" != "$MASTER_SHA" ]; then
exit 0
fi

cd docker

echo "Building docker image for $BUILDKITE_MESSAGE"

docker build . -f Dockerfile -t ubercadence/server:master --build-arg git_branch=$BUILDKITE_COMMIT
docker build . -f Dockerfile -t ubercadence/server:master --build-arg TARGET=server
docker push ubercadence/server:master

docker build . -f Dockerfile-cli -t ubercadence/cli:master --build-arg git_branch=$BUILDKITE_COMMIT
docker build . -f Dockerfile -t ubercadence/server:master-auto-setup --build-arg TARGET=auto-setup
docker push ubercadence/server:master-auto-setup

docker build . -f Dockerfile-cli -t ubercadence/cli:master --build-arg TARGET=cli
docker push ubercadence/cli:master

0 comments on commit a8fd5a6

Please sign in to comment.