Clear stickyness if it is not being used when scheduling decision (#2358

)

service/history/mutableStateBuilder.go

@@ -1379,6 +1379,13 @@ func (e *mutableStateBuilder) AddDecisionTaskScheduledEvent() (*decisionInfo, er
 	taskList := e.executionInfo.TaskList
 	if e.IsStickyTaskListEnabled() {
 		taskList = e.executionInfo.StickyTaskList
+	} else {
+		// It can be because stickyness has expired due to StickyTTL config
+		// In that case we need to clear stickyness so that the LastUpdateTimestamp is not corrupted.
+		// In other cases, clearing stickyness shouldn't hurt anything.
+		// TODO: https://github.com/uber/cadence/issues/2357:
+		//  if we can use a new field(LastDecisionUpdateTimestamp), then we could get rid of it.
+		e.ClearStickyness()
 	}
 	startToCloseTimeoutSeconds := e.executionInfo.DecisionTimeoutValue
 

service/history/service.go

@@ -154,6 +154,7 @@ type Config struct {
 	SearchAttributesTotalSizeLimit    dynamicconfig.IntPropertyFnWithDomainFilter
 
 	// StickyTTL is to expire a sticky tasklist if no update more than this duration
+	// TODO https://github.com/uber/cadence/issues/2357
 	StickyTTL dynamicconfig.DurationPropertyFnWithDomainFilter
 }