mutable state builder coverage (#6454)

* adds some coverage for the mutable state builder's reset
uber · Oct 31, 2024 · 1050f22 · 1050f22
1 parent db91cd1
commit 1050f22
Show file tree

Hide file tree

Showing 2 changed files with 539 additions and 23 deletions.
diff --git a/service/history/execution/mutable_state_builder.go b/service/history/execution/mutable_state_builder.go
@@ -143,10 +143,9 @@ type (
 		// TODO: persist this to db
 		appliedEvents map[string]struct{}
 
-		insertTransferTasks     []persistence.Task
-		insertCrossClusterTasks []persistence.Task
-		insertReplicationTasks  []persistence.Task
-		insertTimerTasks        []persistence.Task
+		insertTransferTasks    []persistence.Task
+		insertReplicationTasks []persistence.Task
+		insertTimerTasks       []persistence.Task
 
 		workflowRequests map[persistence.WorkflowRequest]struct{}
 
@@ -1348,12 +1347,6 @@ func (e *mutableStateBuilder) AddTransferTasks(
 	e.insertTransferTasks = append(e.insertTransferTasks, transferTasks...)
 }
 
-func (e *mutableStateBuilder) AddCrossClusterTasks(
-	crossClusterTasks ...persistence.Task,
-) {
-	e.insertCrossClusterTasks = append(e.insertCrossClusterTasks, crossClusterTasks...)
-}
-
 // TODO convert AddTimerTasks to prepareTimerTasks
 func (e *mutableStateBuilder) AddTimerTasks(
 	timerTasks ...persistence.Task,
@@ -1374,10 +1367,6 @@ func (e *mutableStateBuilder) DeleteTransferTasks() {
 	e.insertTransferTasks = nil
 }
 
-func (e *mutableStateBuilder) DeleteCrossClusterTasks() {
-	e.insertCrossClusterTasks = nil
-}
-
 func (e *mutableStateBuilder) DeleteTimerTasks() {
 	e.insertTimerTasks = nil
 }
@@ -1483,10 +1472,9 @@ func (e *mutableStateBuilder) CloseTransactionAsMutation(
 		NewBufferedEvents:         e.updateBufferedEvents,
 		ClearBufferedEvents:       e.clearBufferedEvents,
 
-		TransferTasks:     e.insertTransferTasks,
-		CrossClusterTasks: e.insertCrossClusterTasks,
-		ReplicationTasks:  e.insertReplicationTasks,
-		TimerTasks:        e.insertTimerTasks,
+		TransferTasks:    e.insertTransferTasks,
+		ReplicationTasks: e.insertReplicationTasks,
+		TimerTasks:       e.insertTimerTasks,
 
 		WorkflowRequests: convertWorkflowRequests(e.workflowRequests),
 
@@ -1563,10 +1551,9 @@ func (e *mutableStateBuilder) CloseTransactionAsSnapshot(
 		SignalInfos:         convertPendingSignalInfos(e.pendingSignalInfoIDs),
 		SignalRequestedIDs:  convertStringSetToSlice(e.pendingSignalRequestedIDs),
 
-		TransferTasks:     e.insertTransferTasks,
-		CrossClusterTasks: e.insertCrossClusterTasks,
-		ReplicationTasks:  e.insertReplicationTasks,
-		TimerTasks:        e.insertTimerTasks,
+		TransferTasks:    e.insertTransferTasks,
+		ReplicationTasks: e.insertReplicationTasks,
+		TimerTasks:       e.insertTimerTasks,
 
 		WorkflowRequests: convertWorkflowRequests(e.workflowRequests),
 
@@ -1675,7 +1662,6 @@ func (e *mutableStateBuilder) cleanupTransaction() error {
 	e.nextEventIDInDB = e.GetNextEventID()
 
 	e.insertTransferTasks = nil
-	e.insertCrossClusterTasks = nil
 	e.insertReplicationTasks = nil
 	e.insertTimerTasks = nil