-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
zapslog: Support for a custom mapping of slog.Level to zap.Level #1413
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: junya koyama <[email protected]>
Signed-off-by: junya koyama <[email protected]>
…kiidou/zap into feature/custom-mapping-level
Signed-off-by: junya koyama <[email protected]>
@sywhang please take a look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1413 +/- ##
=======================================
Coverage 98.63% 98.63%
=======================================
Files 53 54 +1
Lines 2997 3002 +5
=======================================
+ Hits 2956 2961 +5
Misses 32 32
Partials 9 9 ☔ View full report in Codecov by Sentry. |
The reason for drafting this What do you think? https://pkg.go.dev/log/slog#example-HandlerOptions-CustomLevels |
summary
zapslog.WithConvertLeveler
not given, the behavior is not changed.tests