Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zapcore: Ignore nil Entry.Time in encoders #1369

Merged
merged 3 commits into from
Oct 5, 2023

test: Verify console encoder behavior

f9de9df
Select commit
Loading
Failed to load commit list.
Merged

zapcore: Ignore nil Entry.Time in encoders #1369

test: Verify console encoder behavior
f9de9df
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 5, 2023 in 1s

98.42% (target 95.00%)

View this Pull Request on Codecov

98.42% (target 95.00%)

Details

Codecov Report

Merging #1369 (f9de9df) into master (54430cb) will increase coverage by 0.14%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1369      +/-   ##
==========================================
+ Coverage   98.28%   98.42%   +0.14%     
==========================================
  Files          53       53              
  Lines        3493     3493              
==========================================
+ Hits         3433     3438       +5     
+ Misses         50       46       -4     
+ Partials       10        9       -1     
Files Coverage Δ
zapcore/console_encoder.go 100.00% <100.00%> (ø)
zapcore/json_encoder.go 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more