Skip to content

Commit

Permalink
Use semver dependency on Apache Thrift (#83)
Browse files Browse the repository at this point in the history
Apache Thrift made a breaking api change in the 0.11 series. This package relies on the ~0.10 API. 
Currently downstream packages using dep do not inherit this package's transitive dependency constraint on apache thrift because dep does not consider revision pins when importing constraints from alternate dependency managers. By using a semver range instead of a direct pin.

Another parallel path is to propose amending Dep to consider Glide revision pins as valid transitive constraints. We can do that unilaterally in our fork of dep but it would be much better if we worked with upstream. This pull request gets us out of the immediate pain and unblocks migration to dep within Uber.
  • Loading branch information
bayesianmind authored and robskillington committed Jul 18, 2018
1 parent 79f2a33 commit ff17f3c
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 12 deletions.
22 changes: 11 additions & 11 deletions glide.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion glide.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ import:
- package: github.com/m3db/prometheus_procfs
version: 1878d9fbb537119d24b21ca07effd591627cd160
- package: github.com/apache/thrift
version: 9549b25c77587b29be4e0b5c258221a4ed85d37a
version: '>=0.9.3, <0.11.0'
subpackages:
- lib/go/thrift
- package: go.uber.org/atomic
Expand Down

0 comments on commit ff17f3c

Please sign in to comment.