Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fossa action to v1.1.0 #118

Merged
merged 1 commit into from
Oct 11, 2023
Merged

Update fossa action to v1.1.0 #118

merged 1 commit into from
Oct 11, 2023

Conversation

r-hang
Copy link
Contributor

@r-hang r-hang commented Oct 11, 2023

Update fossa action to v1.1.0

The FOSSA check has been failing for a while with
fossa-actions@v1 Error: Input required and not supplied: api-key

This has caused the dependabot queue to backup, we also can't merge them
manually in sally because this check is required.

Updating the version seems to cause the check to run successfully again.

Other repositories have run into the same issue
ref: getsentry/self-hosted#1351

@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Merging #118 (e7e6599) into master (b1dc33f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #118   +/-   ##
=======================================
  Coverage   74.03%   74.03%           
=======================================
  Files           3        3           
  Lines         104      104           
=======================================
  Hits           77       77           
  Misses         23       23           
  Partials        4        4           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

The FOSSA check has been failing for a while with
fossa-actions@v1 Error: Input required and not supplied: api-key

This has caused the dependabot queue to backup, can we can't merge them
manually in sally because this check is required.

Updating the version seems to cause the check to run successfully again.

Other repositories have run into the same issue
ref: getsentry/self-hosted#1351
@r-hang r-hang merged commit f3a3b27 into master Oct 11, 2023
6 checks passed
@r-hang r-hang deleted the rhang/fix-fossa-workflow branch October 11, 2023 17:52
@abhinav
Copy link
Collaborator

abhinav commented Oct 12, 2023

This has caused the dependabot queue to backup, we also can't merge them manually in sally because this check is required.

This is because dependabot PRs don't run with the standard repository secrets by default -- because that's a supply chain attack vector (e.g., ship a malicious update to a small dependency you happen to maintain, let dependabot create PRs on all repositories that use it, steal credentials).

The reason your upgrade PR works is because the author of the PR is a maintainer, not dependabot, so it runs with regular secrets. You can verify this: go to any dependabot PR, do a commit --allow-empty and push a new commit onto that PR. Now that there's a maintainer involved in the PR, it'll run with proper secrets again.

To fix this, you need to separately set Dependabot secrets: https://docs.github.com/en/code-security/dependabot/working-with-dependabot/automating-dependabot-with-github-actions#accessing-secrets. If you're able to do it successfully on this repository, it may be worth setting up Org-level dependabot secrets for fossa.

@r-hang
Copy link
Contributor Author

r-hang commented Oct 12, 2023

Thanks @abhinav, i'll follow up.

@mway mway mentioned this pull request Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants