Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove no longer needed tracestack_new.go file #123

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

alexandear
Copy link
Contributor

The PR moves isTraceStack from the tracestack_new.go to options.go. The file tracestack_new.go became unnecessary after #79.

Copy link

codecov bot commented Jun 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.14%. Comparing base (7f1444f) to head (22358d0).

Current head 22358d0 differs from pull request most recent head 8afe7a5

Please upload reports for the commit 8afe7a5 to get more accurate results.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #123   +/-   ##
=======================================
  Coverage   99.14%   99.14%           
=======================================
  Files           6        5    -1     
  Lines         234      234           
=======================================
  Hits          232      232           
  Misses          1        1           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@abhinav
Copy link
Collaborator

abhinav commented Jun 5, 2024

The lint error seems to be because of golangci-lint upgrade.
The newest version does not exclude fmt.* by default in errcheck.

@abhinav
Copy link
Collaborator

abhinav commented Jun 5, 2024

The lint error seems to be because of golangci-lint upgrade. The newest version does not exclude fmt.* by default in errcheck.

@sywhang I think to fix that, we may need to change the golangci config—or just fix the lint issue. Up to you.

@sywhang
Copy link
Contributor

sywhang commented Jun 5, 2024

yeah, let me fix that.

@sywhang sywhang force-pushed the cleanup-unused-tracestack-new branch from 22358d0 to 8afe7a5 Compare June 5, 2024 19:54
@sywhang sywhang merged commit 3b6d3dd into uber-go:master Jun 5, 2024
5 checks passed
@alexandear alexandear deleted the cleanup-unused-tracestack-new branch June 5, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants