Fix lint and upgrade versions to 1.21/1.22 #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prashantv
force-pushed
the
prashant/fix-test-1.20
branch
from
c89b649
to
ababdaf
Compare
prashantv
changed the title
sywhang
approved these changes
Apr 13, 2024
abhinav
approved these changes
Apr 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #120, I accidentally merged the PR without waiting for all tests to run, and missed that 1.20 tests are failing.
Lint is failing because of how we skip golangci-lint run in the action and use the Makefile. Use the same logic as zap to skip lint.
Tests are failing on 1.20 as stack elision doesn't kick in for the test. From 1.21 onwards, it does kick in. Rather than try to make the test trigger stack elision on 1.20, let's bump the versions to 1.21 / 1.22.