docs: update to node 20, re-upgrade got to 14.0.0, update other deps #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #79 +/- ##
=======================================
Coverage 87.20% 87.20%
=======================================
Files 32 32
Lines 2603 2603
=======================================
Hits 2270 2270
Misses 269 269
Partials 64 64 ☔ View full report in Codecov by Sentry. |
JacobOaks
force-pushed
the
joaks/node20
branch
from
ee3b562
to
57dd02a
Compare
We have to revert uber-go#75 because got 14.0.0 requires node 20. This diff updates to node 20 for the docs github workflow. It also re-upgrade got to 14.0.0. Initially, this causes another issue when building the docs: ``` tip Apply plugin mermaidjs (i.e. "vuepress-plugin-mermaidjs") ... [info] [webpackbar] Compiling Client [info] [webpackbar] Compiling Server /home/runner/work/cff/cff/docs/node_modules/loader-runner/lib/LoaderRunner.js:114 throw e; ^ Error: error:0308010C:digital envelope routines::unsupported at new Hash (node:internal/crypto/hash:68:19) at Object.createHash (node:crypto:138:10) at module.exports (/home/runner/work/cff/cff/docs/node_modules/webpack/lib/util/createHash.js:135:53) at NormalModule._initBuildHash (/home/runner/work/cff/cff/docs/node_modules/webpack/lib/NormalModule.js:417:16) at handleParseError (/home/runner/work/cff/cff/docs/node_modules/webpack/lib/NormalModule.js:471:10) at /home/runner/work/cff/cff/docs/node_modules/webpack/lib/NormalModule.js:503:5 at /home/runner/work/cff/cff/docs/node_modules/webpack/lib/NormalModule.js:358:12 at /home/runner/work/cff/cff/docs/node_modules/loader-runner/lib/LoaderRunner.js:373:3 at iterateNormalLoaders (/home/runner/work/cff/cff/docs/node_modules/loader-runner/lib/LoaderRunner.js:214:10) at iterateNormalLoaders (/home/runner/work/cff/cff/docs/node_modules/loader-runner/lib/LoaderRunner.js:221:10) at /home/runner/work/cff/cff/docs/node_modules/loader-runner/lib/LoaderRunner.js:236:3 at context.callback (/home/runner/work/cff/cff/docs/node_modules/loader-runner/lib/LoaderRunner.js:111:13) at /home/runner/work/cff/cff/docs/node_modules/cache-loader/dist/index.js:134:7 at /home/runner/work/cff/cff/docs/node_modules/graceful-fs/graceful-fs.js:61:14 at FSReqCallback.oncomplete (node:fs:189:23) { opensslErrorStack: [ 'error:03000086:digital envelope routines::initialization error' ], library: 'digital envelope routines', reason: 'unsupported', code: 'ERR_OSSL_EVP_UNSUPPORTED' } ``` This is apparently a known issue with Node >16. Refs: * https://stackoverflow.com/questions/69692842/error-message-error0308010cdigital-envelope-routinesunsupported * vuejs/vuepress#3136 We can workaround this issue by setting `NODE_OPTIONS=--openssl-legacy-provider` when building the docs, which this PR also does. I tested the docs workflow using this branch and the env var set, and it completed successfully: https://github.com/uber-go/cff/actions/runs/7172095319
JacobOaks
force-pushed
the
joaks/node20
branch
from
57dd02a
to
1d51cb7
Compare
JacobOaks
changed the title
JacobOaks
changed the title
|
@JacobOaks upgrading all the other dependencies solved that issue. we don't need to use the legacy openssl anymore. |
abhinav
changed the title
abhinav
changed the title
|
@r-hang This should supersede the other PR upgrading the same dependency. |
r-hang
approved these changes
Jan 6, 2024
r-hang
added a commit
that referenced
this pull request
Jan 6, 2024
#79 landed but ran into build failures. I was able to reproduce the CI workflow failure by running 'make docs' locally. Reviewing the contents of #79, setting export NODE_OPTIONS=--openssl-legacy-provider passes 'make docs' locally. This PR add this flag option to the docs CI workflow until the SSL issues can be resolved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had to revert #75 because got 14.0.0 requires node 20.
This PR updates to node 20 for the docs github workflow.
It also re-upgrade got to 14.0.0.
This caused another issue when building the docs:
This is apparently a known issue with Node 17.0.0+, which upgrades Node to OpenSSL 3.0. This new version disallows certain legacy operations found to be vulnerable to security attacks.
We can workaround this issue by setting
NODE_OPTIONS=--openssl-legacy-providerwhen building the docs, which this PR also does.
This is not an ideal solution as using the older OpenSSL version.
The issue is resolved by upgrading the other dependencies in our yarn.lock.