Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mountinfo parsing #73

Merged
merged 1 commit into from
Jul 19, 2023
Merged

Conversation

stevenh
Copy link
Contributor

@stevenh stevenh commented Jul 1, 2023

Fix the parsing of mountinfo when super options has fields with spaces in, which is the case on WSL as it includes path=C:\\Program Files\....

Fixes #72

@CLAassistant
Copy link

CLAassistant commented Jul 1, 2023

CLA assistant check
All committers have signed the CLA.

Fix the parsing of mountinfo when super options has fields with spaces
in, which is the case on WSL as it includes path=C:\\Program Files\...

Fixes uber-go#72
Copy link
Contributor

@sywhang sywhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good to me. thanks for adding the test

@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Merging #73 (d391614) into master (d064ede) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #73      +/-   ##
==========================================
+ Coverage   93.36%   93.39%   +0.02%     
==========================================
  Files           9        9              
  Lines         226      227       +1     
==========================================
+ Hits          211      212       +1     
  Misses         11       11              
  Partials        4        4              
Impacted Files Coverage Δ
internal/cgroups/mountpoint.go 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sywhang sywhang merged commit 60f2278 into uber-go:master Jul 19, 2023
6 checks passed
@stevenh stevenh deleted the fix/mountinfo-parsing branch July 20, 2023 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NewMountPointFromLine fails under WSL
4 participants