Add support for reading total memory

[pavolloffay]

Signed-off-by: Pavol Loffay [email protected]

Expose readings from memory.limit_in_bytes in the public API.

[CLAassistant]

All committers have signed the CLA.

[pavolloffay]

cc @abhinav could you please review?

[codecov]

Codecov Report

Merging #30 into master will decrease coverage by 3.79%.
The diff coverage is 52.38%.

@@            Coverage Diff             @@
##           master      #30      +/-   ##
==========================================
- Coverage   91.91%   88.12%   -3.80%     
==========================================
  Files           8        9       +1     
  Lines         198      219      +21     
==========================================
+ Hits          182      193      +11     
- Misses         13       18       +5     
- Partials        3        8       +5     

Impacted Files	Coverage Δ
internal/cgroups/cgroups.go	90.24% <50.00%> (-9.76%)	⬇️
internal/runtime/cpu_quota_linux.go	47.36% <50.00%> (+1.91%)	⬆️
totalmemory/totalmemory.go	60.00% <60.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b685be8...33c2513. Read the comment docs.

[prashantv]

Thanks for the contribution @pavolloffay

This requires adding a new API to automaxprocs, which needs to consider the tradeoffs I've previously documented here: #29

It seems like a separate module that exposes CGroup information would be the best step forward rather than putting this logic into automaxprocs.

[pavolloffay]

Thanks for the response @prashantv. Do you know a project/module where this could be done? Or do you mean creating a submodule in this project that would expose an API to read cgroups?

As the last option I can for this project and expose the read API for memory and CPU quotas.

[pavolloffay]

Closing per the previous comment

[prashantv]

I don't know what a good place for this project should be, but we don't have plans to create that project under uber-go or as part of this project. Thanks @pavolloffay