Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added GH workflow to check code quality #238

Open
wants to merge 3 commits into
base: dev/0.15.0
Choose a base branch
from

Conversation

Gauvino
Copy link
Contributor

@Gauvino Gauvino commented Oct 14, 2023

Checklist

  • I have read the Contributing Guidelines
  • I acknowledge that any submitted code will be licensed under the ISC License
  • I confirm that submitted code is my own work
  • I have tested the code, and confirm that it works

Enviroment

  • Operating System: null
  • Node version: 20.8.0
  • npm version: 10.2.0

Description

This PR adds a workflow for checking the quality of the code with different linters : es-check, eslint, Prettier, stylelint (css, scss)
Needed for working on this PR is the authorization to add all of the differents linters to the project.

@Gauvino Gauvino changed the base branch from master to dev/0.15.0 October 14, 2023 18:31
@Gauvino Gauvino changed the title Create quality-check.yml Added GH workflow to check code quality Oct 14, 2023
@tycrek tycrek added the enhancement New feature or request label Oct 14, 2023
@tycrek tycrek added this to the 0.15.0 milestone Oct 14, 2023
@tycrek
Copy link
Owner

tycrek commented Oct 14, 2023

Looks like the following NPM scripts are required in order for the jobs to run:

  • escheck
  • lint
  • prettier:check
  • stylelint:css
  • build:check

@Gauvino
Copy link
Contributor Author

Gauvino commented Oct 14, 2023

Looks like the following NPM scripts are required in order for the jobs to run:

  • escheck
  • lint
  • prettier:check
  • stylelint:css
  • build:check

Of course its needed but I don't think I can make all the ignore file from linters and other thing like this, don't want to messed up everything.

Look on my fork the branch linters you'll see everything i've tried to done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants