-
-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update flameshot script to be universal #135
Conversation
- wayland support - experimental local screenshots if domain & key are left empty
I have been using this pretty much daily and works great. Thank you. :) |
I'll aim to merge this with ass 0.15.0 and the universal script that exists on that branch. |
I'll do some tweaking to the script, please do give me a headsup before merging |
should be ready now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks awesome; I'll merge in for now and combine it with the flameshot-v2.sh
script at some point.
Checklist
Enviroment
Description
The script now supports Wayland through the help of Wayland native tools (such as grim and slurp) instead of attempting to get Flameshot to work on Sway and other wl-roots based compositors.
Additionally, it fixes a possible bug that went unnoticed with the
if [[ -f $FILE ]]
condition check.Lastly, support for local screenshots are added and any screenshot taken with the script while
KEY
andDOMAIN
values are null will be copied to the clipboard directly instead of throwing an error and exiting the script.tl;dr:
Dependencies: (Wayland)