Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Favicon #183

Open
wants to merge 5 commits into
base: gh-pages
Choose a base branch
from
Open

Add Favicon #183

wants to merge 5 commits into from

Conversation

eppingere
Copy link

No description provided.

@WebReflection
Copy link
Contributor

shouldn't a favicon be just a favicon.ico since that's what browsers would expect by default anyway? This is also quite huge, old browsers unfriendly .

@WebReflection
Copy link
Contributor

Better now. We need a favicon.ico file name on the root of the site.
Such .ico should possibly be at least 32x32 px and ideally with multiple resolutions such: 16x16, 32x32 and 64x64.

Thanks!

@CLAassistant
Copy link

CLAassistant commented Jul 18, 2019

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@twitter twitter deleted a comment Jul 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants