-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated Martinique Country Flag #1116
base: master
Are you sure you want to change the base?
Conversation
Update Martinique Flag 1f1f2-1f1f6
I would redo the SVG a bit: it is not optimized for deficiencies of SVG renderers.
|
About 2 — there’s an exception: one of the filled spaces is really small. E.g. Sweden: just draw the cross, blue fringe is almost invisible and is even part of style. |
Thanks for the insightful comments, @Mercury13! I’ll definitely follow your advice and update my PR accordingly. |
Hi @Mercury13 I’m looking for some advice on how to effectively overlap two shapes. I have two options in mind:
Which approach do you think would work best? Any insights or recommendations would be greatly appreciated! Thanks! |
Fix overlapping issue on Martinique flag SVG
Hi @Mercury13, |
(see SVG’s wireframe) |
“Full overlap” etc are probably meant for embroidery/cutting machines. We should make overlaps for ourselves. |
Conversely, these options meant for embroidery make pixel rendering really horrible. |
Thank you @Mercury13 for the clarification—it makes sense. 👍 |
optimized overlap on martinique flag
@Mercury13 I followed your advice, and it’s really helpful. I noticed that many other flags don’t align with those guidelines. |
Not enough. And I have made for you: |
|
Thank you @Mercury13 for doing this! I now have a much clearer understanding of how to manage overlapping tasks—very interesting. I learned something valuable today, and I appreciate it. I just have one suggestion regarding the optimization of the SVG file itself. SVG Optimization: Enhancing File Size and ReadabilityI've reviewed the current SVG file and propose the following optimizations to reduce file size and improve readability:
Here's a comparison of the original and optimized SVG: - <?xml version="1.0" encoding="UTF-8" standalone="no"?>
<svg
viewBox="0 0 36 36"
version="1.1"
- id="svg3"
- sodipodi:docname="1f1f2-1f1f6.svg"
- inkscape:version="1.4-beta3 (01c8a1c, 2024-08-28, custom)"
- xmlns:inkscape="http://www.inkscape.org/namespaces/inkscape"
- xmlns:sodipodi="http://sodipodi.sourceforge.net/DTD/sodipodi-0.dtd"
xmlns="http://www.w3.org/2000/svg"
- xmlns:svg="http://www.w3.org/2000/svg">
- <defs
- id="defs3" />
- <sodipodi:namedview
- id="namedview3"
- pagecolor="#ffffff"
- bordercolor="#666666"
- borderopacity="1.0"
- inkscape:showpageshadow="2"
- inkscape:pageopacity="0.0"
- inkscape:pagecheckerboard="0"
- inkscape:deskcolor="#d1d1d1"
- inkscape:zoom="32"
- inkscape:cx="16.671875"
- inkscape:cy="26.796875"
- inkscape:window-width="1680"
- inkscape:window-height="998"
- inkscape:window-x="-8"
- inkscape:window-y="-8"
- inkscape:window-maximized="1"
- inkscape:current-layer="svg3" />
<path
d="m 36,27 c 0,2.209 -1.791,4 -4,4 H 4 C 2.9840384,31 2.0564945,30.621157 1.3509404,29.997044 L 9,15 h 24 l 3,3 z"
- id="path1"
- sodipodi:nodetypes="sssccccs" />
fill="#231f1e" />
<path
d="M 36,18 V 9 C 36,6.791 34.209,5 32,5 H 4 C 2.9838056,5 2.0560696,5.3790161 1.3504555,6.0033847 L 6,18 Z"
- id="path2"
- sodipodi:nodetypes="csssccc" />
fill="#00a650" />
<path
d="M 1.351,6.004 1.35,6.003 C 0.522,6.736 0,7.808 0,9 v 18 c 0,1.193 0.522,2.264 1.351,2.997 L 17.5,18 Z"
- id="path3"
- sodipodi:nodetypes="ccssccc" />
fill="#ef1923" />
</svg> These changes result in a smaller file size and improved readability without affecting the SVG's visual output. By removing Inkscape-specific metadata and unnecessary attributes, we make the file more portable and easier to work with in different SVG editing tools. I believe these optimizations strike a good balance between file size reduction and maintaining the SVG's structure. However, I'm open to discussion if you have any other suggestions for further improvements. My optimized version:
I will add it to the PR. |
I wrote: optimize with whatever software you want. In my Unicodia flags are Twemoji-based (made before SVGization of waved Noto flags, and just simpler). Rules are (a bit contradict to Twitter’s!): FlagsThese rules are intended to work around renderer deficiencies. Emoji are intended to be drawn in small size, and rendering SVG leaves half-pixel lines. Also white and black are main colours everywhere.
|
Hi @Mercury13, Thank you for sharing these guidelines! They are really sharp and interesting, and they offer great insights. I’ve reviewed them closely and made sure that my latest shape version aligns with these recommendations. Regarding the flag colors: the flag should be red, green, and black. I’ve used the color values from the Wikipedia SVG reference, where black is set to Looking forward to your feedback! |
Black better replace. Red and green do not really matter, and it’s BETTER to check country’s flag habits and shift to Twitter’s palette. |
I understand your point @Mercury13. Some colors have meaning. Aligning the black color does make sense, and I’ve updated it in the latest commit. Are we good with this now? |
Another interesting point. Honduras: ≈2022 they changed flag to Maya blue, and even gave RGB, but as Twitter uses a bit dull colours, it’s better to find that line of colours in Pantone and choose a bit duller. |
Interesting point @Mercury13 I’ve adjusted the colors of the Martinique flag to match the Pan-African colors already used by countries such as Ethiopia, Ghana, Malawi, and South Africa in the Twemoji flags. |
Great teamwork, @Mercury13! Do you have the necessary access to merge this PR, or do you know who is responsible for handling it? |
A small app to compare local emoji flag to twemoji. (iOS, macOS, Android) https://emoji-flags.netlify.app @Mercury13 Looking forward to your update! |
Hi @WebReflection, When you have a moment, could you kindly take a look at my PR #1116? I’d really appreciate your feedback. Also, I was wondering if this repository is still actively maintained. I’d love to know if there are any plans or updates for its future. I also wanted to mention that I’ve submitted a PR on jdecked/twemoji, Thank you so much for your time! Best regards, |
This pull request addresses issue #623 by updating the Martinique flag. It replaces the previous pull request #624.
This update ensures that the Martinique flag matches the visual style of the rest of the emoji set.
The source is Wikipedia
https://commons.wikimedia.org/wiki/File:Flag-of-Martinique.svg
https://en.wikipedia.org/wiki/Martinique