Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Eliminate typo in README.md #781

Merged
merged 2 commits into from
Jul 16, 2024
Merged

fix: Eliminate typo in README.md #781

merged 2 commits into from
Jul 16, 2024

Conversation

ahmedghanem00
Copy link
Contributor

Fixes

Fixing a typo in README.me file

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

@ahmedghanem00 ahmedghanem00 changed the title Fix typo in README.md Fix: Eliminate typo in README.md Jul 16, 2023
@ahmedghanem00 ahmedghanem00 changed the title Fix: Eliminate typo in README.md fix: Eliminate typo in README.md Jul 16, 2023
AsabuHere
AsabuHere approved these changes Jul 17, 2023
View reviewed changes
Copy link
Contributor

@AsabuHere AsabuHere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ahmedghanem00
Copy link
Contributor Author

@AsabuHere Hi there, Is there any schedule to get this merged ?

@stevebauman
Copy link

Any merge on this? It's literally just two lines in the docs

@ahmedghanem00
Copy link
Contributor Author

ahmedghanem00 commented Jul 15, 2024 •
edited
Loading

Pinging @sbansla @tiwarishubham635 @AsabuHere, As you have been taking on the recent merged PRs here.

@tiwarishubham635 tiwarishubham635 merged commit 4cdba33 into twilio:main Jul 16, 2024
17 checks passed
@tiwarishubham635
Copy link
Contributor

Pinging @sbansla @tiwarishubham635 @AsabuHere, As you have been taking on the recent merged PRs here.

Done

@ahmedghanem00 ahmedghanem00 deleted the fix/patch-1 branch July 16, 2024 01:00
@ahmedghanem00
Copy link
Contributor Author

ahmedghanem00 commented Jul 16, 2024 •
edited
Loading

Finally 😅, Thanks 💚

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AsabuHere AsabuHere AsabuHere approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ahmedghanem00 @stevebauman @tiwarishubham635 @AsabuHere