fix: issues parsing Xcode 16 projects #862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pepicrft
changed the title
kimdv
reviewed
Oct 1, 2024
Sources/XcodeProj/Objects/Files/PBXFileSystemSynchronizedRootGroup.swift
Outdated
Show resolved
Hide resolved
|
@tuist/community-core this is ready for a review 👀 |
danieleformichelli
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #861
This PR contains some Xcode 16-related fixes:
PBXProject.preferredProjectObjectVersionas an integer but in Xcode 16 is encoded as a string. I'm decoding it as a string and converting it to an integer. If Apple supports strings that don't represent integers down the road we'll have to change the internal type.minimizedProjectReferenceProxiesto thePBXProjectobject.SynchronizedRootGroupsare encoded using multiple-lines. I adjusted the internal model to reflect that and ensure there are no diffs when we write the project back.