-
-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: make PBXProject.compatibilityVersion
optional and add PBXProject.preferredProjectObjectVersion
to support Xcode 16
#854
feat: make PBXProject.compatibilityVersion
optional and add PBXProject.preferredProjectObjectVersion
to support Xcode 16
#854
Conversation
It would be nice if I could get some help to tests? |
I just saw that |
c0c897a
to
6401714
Compare
compatibilityVersion
optionalcompatibilityVersion
optional and add preferredProjectObjectVersion
/// An string representation of the PreferredProjectObjectVersion. | ||
public var preferredProjectObjectVersion: String? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be an integer? do you have any example?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes here preferredProjectObjectVersion = 77;
Changed to an Int
instead.
Please review @danieleformichelli
6401714
to
cadc37b
Compare
compatibilityVersion
optional and add preferredProjectObjectVersion
PBXProject.compatibilityVersion
optional and add PBXProject.preferredProjectObjectVersion
to support Xcode 16
@kimdv there seems to be legit issues in the changes. Would you mind looking into them? |
cd840e0
to
c642855
Compare
Should be fixed now. |
@pepicrft I see you changed the PR title? |
e0e8b67
to
fd30168
Compare
@kimdv, @pepicrft, @danieleformichelli, could you please take a look at #861? |
Resolves #837
Short description 📝
This PR will make
compatibilityVersion
optional. Since Xcode 16 this field isn't present anymore.Also I added
preferredProjectObjectVersion
that is also part if Xcode 16 changes.Solution 📦
I'm new to this. So I tried to see if there was ny "16.0" in a fresh and newly created Xcode project, so see if it was renamed.
Could not find any. So I made it optional, so we can decode Xcode 16 projects.
Implementation 👩💻👨💻
preferredProjectObjectVersion