Add otf font files to known file types #788
Merged
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The `allExtensions` dictionary is used to map known file type extensions to `lastKnownFileType` in the pbxproj - Adding `otf` font files to the list Test Plan: - Add any otf font file to Xcode manually - Examine the pbxproj and verify `file` is used as the `lastKnonwFileType` - Read and write the project using `XcodeProj` - Verify no diffs
✅ Deploy Preview for xcodeproj ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
pepicrft
approved these changes
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description 📝
Generated project files with
otffont files were producing diffs when using Xcode due those files not having alastKnownFileTypeset.Solution 📦
allExtensionsdictionary is used to map known file type extensions tolastKnownFileTypein the pbxprojotffont files to the listTest Plan 🛠️
fileis used as thelastKnonwFileTypeXcodeProj