Refactor cache system #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsutaj
commented
May 16, 2024
| if Path(self.problemset_dir / "cache.json").exists(): | ||
| reference_problemset_cache = json.load( | ||
| open(self.problemset_dir / "cache.json") | ||
| cache = RenderResultCache(self.problemset_dir, output_ext) |
There was a problem hiding this comment.
問題セットのキャッシュファイルは構造が変わるが、許容する
tsutaj
commented
May 16, 2024
| output_ext=output_ext, | ||
| problem_ids=valid_problem_ids, | ||
| is_problemset=True, | ||
| force_dump=force_dump or has_diff, |
There was a problem hiding this comment.
どれかの問題で差分が発生していたら、problemset が更新される
（以前は cache の中身で判定していたが、判定方法を変更）
tsutaj
commented
May 16, 2024
tsutaj
commented
May 16, 2024
| cache = self._load_cache() | ||
| return self._setup_cache(cache) | ||
|
|
||
| def _cleanup(self, cache: dict) -> dict: |
There was a problem hiding this comment.
ここで行っているのは、以下の 2 つ
- 不要になった id を列挙し、キャッシュの辞書から削除
- 不要になった id に関係あるファイルを列挙し、ファイルを削除
やや非自明で、一応コメントがあるといいかもだけど、これくらいならなくても読める気もする。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #150
キャッシュ機構をリファクタリング