handle multiple build parameters correctly #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the previous code did not work with the script which accepts multiple build-parameters in the following form: --build-parameters toto=titi --build-parameters tutu=tata
|
Hi @sebdiem, thanks a lot for your contribution and please excuse the late response. Your commit message currently doesn't follow the Conventional Message Convention, therefore no new version would be released after merging, could you please commit your change again with the correct commit mesage (for this change I would suggest "fix"). Also we require a Developer Certificate of Origin (DCO), which is the currently failing check in the PR. If you have any questions, please let me know |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the previous code did not work with the script which accepts multiple build-parameters in the following form:
--build-parameters toto=titi --build-parameters tutu=tata
Description