Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-130671 / 25.04 / Show the key for 2FA in addition to QR code #10876

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

AlexKarpov98
Copy link
Contributor

@AlexKarpov98 AlexKarpov98 commented Oct 16, 2024

Changes:
Added secret from provisioning_uri with copy button as provided in ticket comments.
Screenshot 2024-10-18 at 17 33 18

Testing:
See ticket.

Downstream

Affects Reasoning
Documentation UI update

@AlexKarpov98 AlexKarpov98 self-assigned this Oct 16, 2024
@AlexKarpov98 AlexKarpov98 requested a review from a team as a code owner October 16, 2024 09:02
@AlexKarpov98 AlexKarpov98 requested review from denysbutenko and removed request for a team October 16, 2024 09:02
@bugclerk bugclerk changed the title NAS-130671: Show the key for 2FA in addition to QR code NAS-130671 / 25.04 / Show the key for 2FA in addition to QR code Oct 16, 2024
@bugclerk
Copy link
Contributor

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.00%. Comparing base (d9ab633) to head (256840c).
Report is 16 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10876      +/-   ##
==========================================
+ Coverage   81.81%   82.00%   +0.18%     
==========================================
  Files        1589     1597       +8     
  Lines       55117    56172    +1055     
  Branches     5807     5832      +25     
==========================================
+ Hits        45093    46062     +969     
- Misses      10024    10110      +86     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@denysbutenko denysbutenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we expect user know what this value mean? If not, maybe we may add label like other forms.

Otherwise it looks good.

@stavros-k
Copy link
Contributor

image
Maybe something like this? Where it has a link/button to show the text code

@AlexKarpov98
Copy link
Contributor Author

AlexKarpov98 commented Oct 18, 2024

@denysbutenko @stavros-k
I updated it with a label

Screenshot 2024-10-18 at 17 33 18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants