NAS-131317: Suggested changes

truenas · Oct 14, 2024 · edc649d · edc649d
1 parent c4c7404
commit edc649d
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 3 deletions.
diff --git a/src/app/modules/ix-table/components/ix-table-head/ix-table-head.component.html b/src/app/modules/ix-table/components/ix-table-head/ix-table-head.component.html
@@ -14,7 +14,8 @@
  @if (column.headerTooltip) {
  <ix-tooltip
  class="tooltip"
- [message]="column.headerTooltip | translate">
+ [message]="column.headerTooltip | translate"
+ (click)="$event.stopPropagation()">
  </ix-tooltip>
  }
  </div>

diff --git a/src/app/modules/ix-table/components/ix-table-head/ix-table-head.component.scss b/src/app/modules/ix-table/components/ix-table-head/ix-table-head.component.scss
@@ -10,7 +10,7 @@ tr {
  text-overflow: ellipsis;
  white-space: nowrap;
 
- @media(max-width: $breakpoint-sm) {
+ @media (max-width: $breakpoint-sm) {
  padding: 0 8px;
  }
 
@@ -28,3 +28,12 @@ tr {
  }
  }
 }
+
+.title {
+ align-items: center;
+ display: flex;
+}
+
+ix-tooltip {
+ margin-left: 8px;
+}
diff --git a/.../modules/disks/components/smart-test-result-list/smart-test-result-list.component.spec.ts b/.../modules/disks/components/smart-test-result-list/smart-test-result-list.component.spec.ts
@@ -120,7 +120,7 @@ describe('SmartTestResultListComponent', () => {
 
  it('should show table rows', async () => {
  const expectedRows = [
- ['Disk', 'Description', 'Status', 'Remaining', 'Power On Hours Ago', 'LBA of First Error'],
+ ['Disk', 'Description', 'Status', 'Remaining', expect.stringContaining('Power On Hours Ago'), 'LBA of First Error'],
  ['sda', 'Background long', 'SUCCESS', '0%', 'N/A', 'No errors'],
  ['sda', 'Background short', 'SUCCESS', '50%', 'N/A', 'No errors'],
  ['sda', 'Background short', 'SUCCESS', 'Completed', 'N/A', 'No errors'],