NAS-131753: Allow user to disable access to snapshot directory in UI (#…

…10861)
truenas · Oct 15, 2024 · 11e154f · 11e154f
1 parent b3e120f
commit 11e154f
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/src/app/enums/dataset.enum.ts b/src/app/enums/dataset.enum.ts
@@ -53,11 +53,13 @@ export const datasetSyncLabels = new Map<DatasetSync, string>([
 export enum DatasetSnapdir {
  Visible = 'VISIBLE',
  Hidden = 'HIDDEN',
+ Disabled = 'DISABLED',
 }
 
 export const datasetSnapdirLabels = new Map<DatasetSnapdir, string>([
  [DatasetSnapdir.Visible, T('Visible')],
  [DatasetSnapdir.Hidden, T('Invisible')],
+ [DatasetSnapdir.Disabled, T('Disabled')],
 ]);
 
 export enum DatasetSnapdev {

diff --git a/...nents/dataset-form/sections/other-options-section/other-options-section.component.spec.ts b/...nents/dataset-form/sections/other-options-section/other-options-section.component.spec.ts
@@ -75,7 +75,7 @@ describe('OtherOptionsSectionComponent', () => {
  source: ZfsPropertySource.Inherited,
  },
  snapdir: {
- value: DatasetSnapdir.Visible,
+ value: DatasetSnapdir.Disabled,
  source: ZfsPropertySource.Inherited,
  },
  snapdev: {
@@ -235,6 +235,10 @@ describe('OtherOptionsSectionComponent', () => {
  parent: parentDataset,
  });
 
+ await form.fillForm({
+ 'Snapshot Directory': 'Visible',
+ });
+
  expect(await form.getValues()).toEqual({
  Comments: '',
  'Compression Level': 'LZJB',
@@ -273,7 +277,7 @@ describe('OtherOptionsSectionComponent', () => {
  readonly: OnOff.Off,
  recordsize: inherit,
  snapdev: DatasetSnapdev.Hidden,
- snapdir: DatasetSnapdir.Visible,
+ snapdir: DatasetSnapdir.Disabled,
  special_small_block_size: inherit,
  aclmode: AclMode.Discard,
  acltype: DatasetAclType.Posix,