NAS-129336 / 24.10 / fix installing to nvme boot drives #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugclerk
changed the title
themylogin
approved these changes
Jun 2, 2024
yocalebo
force-pushed
the
NAS-129336
branch
2 times, most recently
from
c10c736
to
70c7604
Compare
|
This PR has been merged and conversations have been locked. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
get_partitionfunction is wrong and doesn't consider nvme drives. It ends up returning/dev/nvme0n1n1. This means it is currently impossible to install SCALE on systems with nvme boot drive. I've already written a method in middleware for checking for partitions on disks and it is agnostic to what type of drive it's checking (i.e. sata/sas/nvme) so this copies most of that logic making the necessary changes for the installer.