Commits on Oct 17, 2024

1. Revert "ata: libata-scsi: Honor the D_SENSE bit for CK_COND=1 and no … …

   …error"
   
   commit fa0db8e568787c665384430eaf2221b299b85367 upstream.
   
   This reverts commit 28ab9769117ca944cb6eb537af5599aa436287a4.
   
   Sense data can be in either fixed format or descriptor format.
   
   SAT-6 revision 1, "10.4.6 Control mode page", defines the D_SENSE bit:
   "The SATL shall support this bit as defined in SPC-5 with the following
   exception: if the D_ SENSE bit is set to zero (i.e., fixed format sense
   data), then the SATL should return fixed format sense data for ATA
   PASS-THROUGH commands."
   
   The libata SATL has always kept D_SENSE set to zero by default. (It is
   however possible to change the value using a MODE SELECT SG_IO command.)
   
   Failed ATA PASS-THROUGH commands correctly respected the D_SENSE bit,
   however, successful ATA PASS-THROUGH commands incorrectly returned the
   sense data in descriptor format (regardless of the D_SENSE bit).
   
   Commit 28ab9769117c ("ata: libata-scsi: Honor the D_SENSE bit for
   CK_COND=1 and no error") fixed this bug for successful ATA PASS-THROUGH
   commands.
   
   However, after commit 28ab9769117c ("ata: libata-scsi: Honor the D_SENSE
   bit for CK_COND=1 and no error"), there were bug reports that hdparm,
   hddtemp, and udisks were no longer working as expected.
   
   These applications incorrectly assume the returned sense data is in
   descriptor format, without even looking at the RESPONSE CODE field in the
   returned sense data (to see which format the returned sense data is in).
   
   Considering that there will be broken versions of these applications around
   roughly forever, we are stuck with being bug compatible with older kernels.
   
   Cc: [email protected] # 4.19+
   Reported-by: Stephan Eisvogel <[email protected]>
   Reported-by: Christian Heusel <[email protected]>
   Closes: https://lore.kernel.org/linux-ide/[email protected]/
   Fixes: 28ab9769117c ("ata: libata-scsi: Honor the D_SENSE bit for CK_COND=1 and no error")
   Reviewed-by: Hannes Reinecke <[email protected]>
   Reviewed-by: Martin K. Petersen <[email protected]>
   Link: https://lore.kernel.org/r/[email protected]
   Signed-off-by: Niklas Cassel <[email protected]>
   Signed-off-by: Greg Kroah-Hartman <[email protected]>

   

   Niklas Cassel authored and usaleem-ix committed Oct 17, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for 4d2c304
   • Browse repository at this point

   Copy the full SHA

   4d2c304 View commit details

   Browse the repository at this point in the history