Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

monitoring-client: add to-disk logging of Bitswap messages #97

Merged
merged 2 commits into from
Sep 16, 2024

Conversation

mrd0ll4r
Copy link
Member

@mrd0ll4r mrd0ll4r commented May 4, 2023

Draft.

This adds to-disk logging for the monitoring client.
Open problems:

  1. The docker setup needs to create files and directories in a mount, which is annoying permission-wise. For now, I fixed this by letting the client run as root, but that creates files and directories as root, which is unwieldy on the host. To fix this, we probably need a small docker entrypoint script that fixes the permissions on the output directory configured in the YAML config file and then launches the client, dropping root as we did before.
  2. The current log file is not finalized correctly on shutdown, because the tasks are not shut down. To fix this, we need to listen for SIGINT as explained here and shut down the main loop, which should cascade to close all channels and whatnot.

@mrd0ll4r mrd0ll4r force-pushed the bitswap-file-logging branch 3 times, most recently from ea5046c to a7114b6 Compare May 8, 2023 10:35
@mrd0ll4r mrd0ll4r force-pushed the bitswap-file-logging branch 4 times, most recently from b6e3b07 to b1ae349 Compare September 16, 2024 15:01
@mrd0ll4r mrd0ll4r merged commit 46c8471 into trudi-group:master Sep 16, 2024
3 checks passed
@mrd0ll4r mrd0ll4r deleted the bitswap-file-logging branch September 16, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant