Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancements #53

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Conversation

Phil-Friderici
Copy link

This PR features enhancement suggestions

  • use empty arrays instead of undef in template
  • Fix template; add missing space at shells

As I prefer to accept only one data type, the removal of support for strings would be on my list as well.
But this will break backward compatibility and therefore I didn't add a commit for this yet.

Based on the work from my other #52, #51, and #50 but it should be easy possible to rebased this commit against any other branch.

You can see the test results in the PR in my fork Phil-Friderici#4

@bschonec
Copy link

bschonec commented Jul 2, 2024

@trlinkin would you be so kind as to accept these very useful changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants