Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boundary Pressure Calculation for FSI #498

Open
wants to merge 69 commits into
base: main
Choose a base branch
from

Conversation

svchb
Copy link
Collaborator

@svchb svchb commented Apr 18, 2024

  • add optional offset
  • use Bernoulli Equation to obtain dynamic pressure contribution

With the new BernoulliPressureExtrapolation on the right side
image

Depends on #599

@svchb svchb requested review from efaulhaber and LasNikas and removed request for efaulhaber April 18, 2024 08:31
Copy link

codecov bot commented Apr 18, 2024

Codecov Report

Attention: Patch coverage is 41.66667% with 21 lines in your changes missing coverage. Please review.

Project coverage is 69.78%. Comparing base (7e7c5ed) to head (5a5e18b).

Files with missing lines Patch % Lines
...chemes/boundary/dummy_particles/dummy_particles.jl 38.23% 21 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #498      +/-   ##
==========================================
- Coverage   69.93%   69.78%   -0.16%     
==========================================
  Files          86       86              
  Lines        5129     5146      +17     
==========================================
+ Hits         3587     3591       +4     
- Misses       1542     1555      +13     
Flag Coverage Δ
unit 69.78% <41.66%> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@svchb svchb mentioned this pull request May 27, 2024
@svchb svchb requested a review from efaulhaber July 26, 2024 13:29
Comment on lines 483 to 493
pressure[particle] += (pressure_offset
+
particle_pressure(v_neighbor_system, neighbor_system,
neighbor)
+
dynamic_pressure(boundary_density_calculator, density_neighbor,
v, v_neighbor_system, particle, neighbor,
system, neighbor_system)
+
dot(resulting_acceleration,
density_neighbor * pos_diff)) * kernel_weight
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
pressure[particle] += (pressure_offset
+
particle_pressure(v_neighbor_system, neighbor_system,
neighbor)
+
dynamic_pressure(boundary_density_calculator, density_neighbor,
v, v_neighbor_system, particle, neighbor,
system, neighbor_system)
+
dot(resulting_acceleration,
density_neighbor * pos_diff)) * kernel_weight
# Bernoulli's principle
stagnation_pressure = pressure_offset +
particle_pressure(v_neighbor_system, neighbor_system, neighbor) +
dynamic_pressure(boundary_density_calculator, density_neighbor,
v, v_neighbor_system, particle, neighbor,
system, neighbor_system)
hydraulic_head = dot(resulting_acceleration, density_neighbor * pos_diff)
pressure[particle] += (stagnation_pressure + hydraulic_head) * kernel_weight

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But this is now used by both the adami and bernoulli pressure condition? Is this not just confusing?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm it's the same principle. I was wondering if this might increase readability.

docs/src/systems/boundary.md Outdated Show resolved Hide resolved
src/schemes/boundary/dummy_particles/dummy_particles.jl Outdated Show resolved Hide resolved
src/schemes/boundary/dummy_particles/dummy_particles.jl Outdated Show resolved Hide resolved
src/schemes/boundary/dummy_particles/dummy_particles.jl Outdated Show resolved Hide resolved
src/schemes/boundary/dummy_particles/dummy_particles.jl Outdated Show resolved Hide resolved
src/schemes/boundary/dummy_particles/dummy_particles.jl Outdated Show resolved Hide resolved
src/schemes/boundary/dummy_particles/dummy_particles.jl Outdated Show resolved Hide resolved
src/schemes/boundary/dummy_particles/dummy_particles.jl Outdated Show resolved Hide resolved
src/schemes/boundary/dummy_particles/dummy_particles.jl Outdated Show resolved Hide resolved
@svchb svchb requested a review from LasNikas September 27, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants