-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Boundary Pressure Calculation for FSI #498
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #498 +/- ##
==========================================
- Coverage 69.93% 69.78% -0.16%
==========================================
Files 86 86
Lines 5129 5146 +17
==========================================
+ Hits 3587 3591 +4
- Misses 1542 1555 +13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
da17b41
to
b82e338
Compare
pressure[particle] += (pressure_offset | ||
+ | ||
particle_pressure(v_neighbor_system, neighbor_system, | ||
neighbor) | ||
+ | ||
dynamic_pressure(boundary_density_calculator, density_neighbor, | ||
v, v_neighbor_system, particle, neighbor, | ||
system, neighbor_system) | ||
+ | ||
dot(resulting_acceleration, | ||
density_neighbor * pos_diff)) * kernel_weight |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pressure[particle] += (pressure_offset | |
+ | |
particle_pressure(v_neighbor_system, neighbor_system, | |
neighbor) | |
+ | |
dynamic_pressure(boundary_density_calculator, density_neighbor, | |
v, v_neighbor_system, particle, neighbor, | |
system, neighbor_system) | |
+ | |
dot(resulting_acceleration, | |
density_neighbor * pos_diff)) * kernel_weight | |
# Bernoulli's principle | |
stagnation_pressure = pressure_offset + | |
particle_pressure(v_neighbor_system, neighbor_system, neighbor) + | |
dynamic_pressure(boundary_density_calculator, density_neighbor, | |
v, v_neighbor_system, particle, neighbor, | |
system, neighbor_system) | |
hydraulic_head = dot(resulting_acceleration, density_neighbor * pos_diff) | |
pressure[particle] += (stagnation_pressure + hydraulic_head) * kernel_weight |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But this is now used by both the adami and bernoulli pressure condition? Is this not just confusing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm it's the same principle. I was wondering if this might increase readability.
Co-authored-by: Erik Faulhaber <[email protected]>
…mi_pressure_changes
With the new BernoulliPressureExtrapolation on the right side
Depends on #599