Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Standard weak-form DG for the spherical shallow water equations in covariant form #37

Draft
wants to merge 91 commits into
base: main
Choose a base branch
from

Conversation

tristanmontoya
Copy link
Member

@tristanmontoya tristanmontoya commented Sep 16, 2024

This extends upon #31. Now we can solve the shallow water equations in covariant form with P4estMesh, although nearly all of the kernels called by rhs! had to be rewritten. All the geometric terms are computed independently of the particular mesh (does not require structured grids) so it should extend to other grid types like icosahedral, etc. without too much effort.

tristanmontoya and others added 30 commits July 18, 2024 21:57
…tion in Trixi.jl (cherry-picked from f45378e)

Co-authored-by: Tristan Montoya <[email protected]>
…ltype() and ndims() functions for new struct
@tristanmontoya tristanmontoya marked this pull request as draft September 16, 2024 23:07
Copy link

codecov bot commented Sep 17, 2024

Codecov Report

Attention: Patch coverage is 91.58700% with 44 lines in your changes missing coverage. Please review.

Project coverage is 85.59%. Comparing base (7079c44) to head (bf01678).

Files with missing lines Patch % Lines
...em_p4est/containers_2d_manifold_in_3d_covariant.jl 76.74% 30 Missing ⚠️
src/callbacks_step/save_solution_covariant.jl 80.95% 12 Missing ⚠️
...vers/dgsem_p4est/dg_2d_manifold_in_3d_covariant.jl 98.55% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #37      +/-   ##
==========================================
+ Coverage   81.78%   85.59%   +3.81%     
==========================================
  Files           8       14       +6     
  Lines         829     1340     +511     
==========================================
+ Hits          678     1147     +469     
- Misses        151      193      +42     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants