Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add all routines to set up a voronoi mesh #6

Merged
merged 12 commits into from
Feb 6, 2024

Conversation

bennibolm
Copy link
Collaborator

@bennibolm bennibolm commented Jan 26, 2024

Open issue for later: What variables do I actually need for the implementation of the FV method in Trixi.jl? For which variables does it make sense to convert the array to Julia-typical types (e.g. Int64) and when? Can't happen directly after creation, since the following routines require C types.

@sloede
Copy link
Member

sloede commented Jan 26, 2024

For which variables does it make sense to convert the array to Julia-typical types (e.g. Int64) and when? Can't happen directly after creation, since the following routines require C types.

Maybe we should just not convert anything to Julia types in this package and instead leave it to the user? Alternatively, we could provide additional methods for those functions that accept the return element type as the first argument, i.e., foo(arg1, arg2) gets foo(Float64, arg1, arg2) etc.

For now, though, I'd just remove the conversion to default Julia types as you did 👍

@codecov-commenter
Copy link

codecov-commenter commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3ccdfe1) 100.00% compared to head (2b0e6e7) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main        #6   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines            7        34   +27     
=========================================
+ Hits             7        34   +27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bennibolm bennibolm marked this pull request as ready for review February 6, 2024 12:18
@bennibolm
Copy link
Collaborator Author

I will add the routine's doctrings in another PR. So, this one here is ready to review/merge. Do you @sloede @simonechiocchetti want to take a look before I merge it?

Copy link
Member

@sloede sloede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a real review (I will not be able to do this in general), but two minor thoughts

src/Smesh.jl Show resolved Hide resolved
src/Smesh.jl Outdated Show resolved Hide resolved
@bennibolm bennibolm enabled auto-merge (squash) February 6, 2024 15:32
@bennibolm bennibolm merged commit eda7f43 into trixi-framework:main Feb 6, 2024
10 checks passed
@bennibolm bennibolm deleted the setting-up-voronoi-mesh branch February 6, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants