-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add real-life SPH benchmarks #29
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #29 +/- ##
=======================================
Coverage 88.34% 88.34%
=======================================
Files 16 16
Lines 489 489
=======================================
Hits 432 432
Misses 57 57
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
8230ddc
to
94fe348
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be included in the benchmark testsuite?
Also do you want to add a file to actually run a benchmark?
Thanks! Forgot to add it to the tests. |
…hborhoodSearch.jl into ef/benchmarks2
Depends on trixi-framework/TrixiParticles.jl#580. |
@efaulhaber The tests still fail. |
Yes, waiting for the next release of TrixiParticles. |
The errors are fixed by trixi-framework/TrixiParticles.jl#580. |
…hborhoodSearch.jl into ef/benchmarks2
Based on trixi-framework/TrixiParticles.jl#550.