Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add real-life SPH benchmarks #29

Merged
merged 16 commits into from
Aug 7, 2024
Merged

Add real-life SPH benchmarks #29

merged 16 commits into from
Aug 7, 2024

Conversation

efaulhaber
Copy link
Member

@efaulhaber efaulhaber commented Jun 20, 2024

@efaulhaber efaulhaber mentioned this pull request Jun 20, 2024
Copy link

codecov bot commented Jun 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.34%. Comparing base (914acf7) to head (d8b1912).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #29   +/-   ##
=======================================
  Coverage   88.34%   88.34%           
=======================================
  Files          16       16           
  Lines         489      489           
=======================================
  Hits          432      432           
  Misses         57       57           
Flag Coverage Δ
unit 88.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@efaulhaber efaulhaber marked this pull request as ready for review June 26, 2024 07:31
Copy link
Collaborator

@svchb svchb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be included in the benchmark testsuite?
Also do you want to add a file to actually run a benchmark?

@efaulhaber
Copy link
Member Author

Thanks! Forgot to add it to the tests.

@efaulhaber efaulhaber added the enhancement New feature or request label Jun 26, 2024
@efaulhaber efaulhaber marked this pull request as draft June 27, 2024 11:33
@efaulhaber efaulhaber marked this pull request as ready for review July 18, 2024 08:18
@efaulhaber
Copy link
Member Author

Depends on trixi-framework/TrixiParticles.jl#580.

svchb
svchb previously approved these changes Aug 5, 2024
@svchb
Copy link
Collaborator

svchb commented Aug 6, 2024

@efaulhaber The tests still fail.

@efaulhaber
Copy link
Member Author

Yes, waiting for the next release of TrixiParticles.

@efaulhaber
Copy link
Member Author

The errors are fixed by trixi-framework/TrixiParticles.jl#580.

@efaulhaber efaulhaber closed this Aug 6, 2024
@efaulhaber efaulhaber reopened this Aug 6, 2024
@svchb svchb merged commit 7df4f7f into main Aug 7, 2024
10 checks passed
@svchb svchb deleted the ef/benchmarks2 branch August 7, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants