Readme - On Spack #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* This aids in dependency resolution for other projects, like hohqmesh
* CMake error messages from HOHQMesh suggest it's looking for ftobjectlibrary-config.cmake
* set_and_check is unknown to CMake when installing HOHQMesh via spack
Co-authored-by: Michael Schlottke-Lakemper <[email protected]>
We believe this can resolve issues with how environment variables are passed to Windows environments when cmake is called. Co-authored-by: Michael Schlottke-Lakemper <[email protected]>
* Testing to see if this patches the issue with Windows systems builds
* Instructions are also included to show how to add a new release to the Spack package manager
sloede
requested changes
Jul 11, 2021
|
|
||
|
|
||
| To add a new FTObjectLibrary release to Spack, | ||
| 1. Fork the Spack repository on Github to your personal account or the trixi-framework organization account. |
There was a problem hiding this comment.
Suggested change
| 1. Fork the Spack repository on Github to your personal account or the trixi-framework organization account. | |
| 1. Fork the Spack repository on GitHub. |
Forks should never go into the organization account.
|
|
||
| 9. When ready, commit your changes and push them to your Github repository. | ||
|
|
||
| 10. Open a Pull Request with `github.com/spack/spack` to merge your changes with the `spack/spack/develop` branch. |
There was a problem hiding this comment.
Suggested change
| 10. Open a Pull Request with `github.com/spack/spack` to merge your changes with the `spack/spack/develop` branch. | |
| 10. Open a Pull Request against `github.com/spack/spack` to merge your changes with the `spack/spack/develop` branch. |
I think "open a pull request against a repo/branch" is the typical GH lingo
DavidAKopriva
approved these changes
Mar 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added some documentation for installing FTObjectLibrary via spack. Additionally, there are notes on how to contribute new version releases for FTOL to the Spack package manager.
Ideally, you should be able to install Spack using the instructions provided.