Build: Update TRT release branch referenced in model gen file #7693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mc-nv
reviewed
Oct 11, 2024
| @@ -512,7 +512,7 @@ chmod -R 777 $FORMATDESTDIR | |||
| python3 $SRCDIR/gen_qa_trt_data_dependent_shape.py --models_dir=$DATADEPENDENTDIR | |||
| chmod -R 777 $DATADEPENDENTDIR | |||
| # Make shared library for custom Hardmax plugin. | |||
| (git clone -b release/10.0 https://github.com/NVIDIA/TensorRT.git && \ | |||
| (git clone -b release/10.5 https://github.com/NVIDIA/TensorRT.git && \ | |||
There was a problem hiding this comment.
This value is hardcoded and may bother us on next release, I would suggest following:
(git clone -b release/$(echo ${TRT_VERSION} | cut -d . -f -2) https://github.com/NVIDIA/TensorRT.git && \
Sure it's not a very flexible solution, but at least it will give us some time to stay away of changing it each release.
mc-nv
approved these changes
Oct 11, 2024
|
is it need to be closed in favor of: #7712 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do?
Update TRT release branch referenced in model gen file. Looks like this branch name is currently updated manually and only referenced in one place. Example pipeline is shared in JIRA ticket.
Checklist
<commit_type>: <Title>Commit Type:
Check the conventional commit type
box here and add the label to the github PR.