Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update openvino runtime version to 2024.3 #7585

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

dtrawins
Copy link

@dtrawins dtrawins commented Sep 2, 2024

What does the PR do?

Update OpenVINO Runtime version in OpenVINO backend

Checklist

  • I have read the Contribution guidelines and signed the Contributor License
    Agreement
  • PR title reflects the change and is of format <commit_type>: <Title>
  • Changes are described in the pull request.
  • Related issues are referenced.
  • Populated github labels field
  • Added test plan and verified test passes.
  • Verified that the PR passes existing CI.
  • I ran pre-commit locally (pre-commit install, pre-commit run --all)
  • Verified copyright is correct on all changed files.
  • Added succinct git squash message before merging ref.
  • All template sections are filled out.
  • Optional: Additional screenshots for behavior/output changes with before/after.

Commit Type:

Check the conventional commit type
box here and add the label to the github PR.

  • build
  • ci
  • docs
  • feat
  • fix
  • perf
  • refactor
  • revert
  • style
  • test

Related PRs:

OV Backend

Where should the reviewer start?

Test plan:

confirm if ONNX backend works fine including Openvino with different OpenVINO Runtime versions
windows build to be verified

Caveats:

OV Runtime in ONNX backend could be updated independently later

Background

Current OpenVINO runtime is 3 releases behind the latest

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

NA

@nnshah1
Copy link
Contributor

nnshah1 commented Sep 25, 2024

@dtrawins - do we want to go ahead and update to 2024.4 and test against that?

@nnshah1
Copy link
Contributor

nnshah1 commented Oct 21, 2024

@dtrawins - question: in this MR, the ORT version of OpenVINO is left unchanged.

When we tried to update both:
r24.10...pvijayakrish-24.10-openvino-vllm
triton-inference-server/onnxruntime_backend@r24.10...pvijayakrish-24.10-openvino-vllm

We ran into an issue with a missing libtbb dependency (was included previously but is missing when using the latest)

Do you have any guidance on the ORT version and libtbb?

@pvijayakrish for viz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants