Review feedback: Add note in ModelInstanceInitialize that it may be c…

…alled concurrently and should be thread-safe
triton-inference-server · Aug 4, 2023 · c7b7e9f · c7b7e9f
1 parent 324fefd
commit c7b7e9f
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/src/onnxruntime.cc b/src/onnxruntime.cc
@@ -2674,6 +2674,10 @@ TRITONBACKEND_ModelFinalize(TRITONBACKEND_Model* model)
 TRITONBACKEND_ISPEC TRITONSERVER_Error*
 TRITONBACKEND_ModelInstanceInitialize(TRITONBACKEND_ModelInstance* instance)
 {
+  // NOTE: If the corresponding TRITONBACKEND_BackendAttribute is enabled by the
+  // backend for parallel model instance loading, the
+  // TRITONBACKEND_ModelInstanceInitialize may be called concurrently.
+  // Therefore, this function should be thread-safe.
   const char* cname;
   RETURN_IF_ERROR(TRITONBACKEND_ModelInstanceName(instance, &cname));
   std::string name(cname);