Require rustls-platform-verifier 0.3.2 to avoid multiple crypto backends #667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…backends rustls-platform-verifier 0.3.2 fixes a dependency issue leading trillium-rustls to have *both* aws-lc-rs and ring in its dependencies, even if only depending on aws-lc-rs.
joshtriplett
force-pushed
the
require-new-rustls-platform-verifier
branch
from
1878fc2
to
d37cc17
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #667 +/- ##
=======================================
Coverage 47.80% 47.80%
=======================================
Files 187 187
Lines 7372 7372
=======================================
Hits 3524 3524
Misses 3848 3848 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rustls-platform-verifier 0.3.2 fixes a dependency issue leading
trillium-rustls to have both aws-lc-rs and ring in its dependencies,
even if only depending on aws-lc-rs.
Fixes: #664