Merge pull request #190 from gbprod/fix-param-attributes

feat: allows attributes on promoted properties
tree-sitter · Oct 20, 2023 · 0e02e7f · 0e02e7f
2 parents 92a98ad + 8672cf6
commit 0e02e7f
Show file tree

Hide file tree

Showing 5 changed files with 66,458 additions and 65,451 deletions.
diff --git a/grammar.js b/grammar.js
@@ -451,6 +451,7 @@ module.exports = grammar({
     ),
 
     property_promotion_parameter: $ => seq(
+      optional(field('attributes', $.attribute_list)),
       field('visibility', $.visibility_modifier),
       field('readonly', optional($.readonly_modifier)),
       field('type', optional($._type)), // Note: callable is not a valid type here, but instead of complicating the parser, we defer this checking to any intelligence using the parser

diff --git a/src/grammar.json b/src/grammar.json
@@ -2333,6 +2333,22 @@
     "property_promotion_parameter": {
       "type": "SEQ",
       "members": [
+        {
+          "type": "CHOICE",
+          "members": [
+            {
+              "type": "FIELD",
+              "name": "attributes",
+              "content": {
+                "type": "SYMBOL",
+                "name": "attribute_list"
+              }
+            },
+            {
+              "type": "BLANK"
+            }
+          ]
+        },
         {
           "type": "FIELD",
           "name": "visibility",

diff --git a/src/node-types.json b/src/node-types.json
@@ -3767,6 +3767,16 @@
     "type": "property_promotion_parameter",
     "named": true,
     "fields": {
+      "attributes": {
+        "multiple": false,
+        "required": false,
+        "types": [
+          {
+            "type": "attribute_list",
+            "named": true
+          }
+        ]
+      },
       "default_value": {
         "multiple": false,
         "required": false,