feat: add menhir grammar to this repo
#93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The main change seems to be that you're including the full ocaml grammar, but language injections seem to be a better solution for that. That's what tree-sitter-ocamllex and many other tree-sitter grammars are doing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was wondering if you would be interested in having more of the OCaml and OCaml-related grammars all live in the same repo, so that they can share the implementation of OCaml highlighting.
This removed some of the more complicated parts of the grammar found here: https://github.com/Kerl13/tree-sitter-menhir/ because it can share the definitions for OCaml itself.
I'm happy to explain more about what I was thinking here, but I would also be interested in adding
ocamllex, andcrambased grammars here if that would be helpful.Thanks!