Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regenerate bindings #311

Closed
wants to merge 2 commits into from

Conversation

segevfiner
Copy link

@segevfiner segevfiner commented Apr 2, 2024

Still need to update the GitHub Actions workflows to produce prebuilds for Node.js, etc.

Checklist:

  • All tests pass in CI.
  • The script/parse-examples passes without issues.
  • There are sufficient tests for the new fix/feature.
  • Grammar rules have not been renamed unless absolutely necessary.
  • The conflicts section hasn't grown too much.
  • The parser size hasn't grown too much (check the value of STATE_COUNT in src/parser.c).

Copy link
Member

@ObserverOfTime ObserverOfTime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should either remove the existing swift bindings or the generated ones.

@amaanq
Copy link
Member

amaanq commented Apr 5, 2024

superseded by #312, sorry there were just a lot of little things to fill in/update

@amaanq amaanq closed this Apr 5, 2024
@segevfiner
Copy link
Author

That's fine. I submitted this to try and coax some progress on updating the grammars.

@segevfiner segevfiner deleted the regenerate-bindings branch April 5, 2024 12:39
@amaanq
Copy link
Member

amaanq commented Apr 5, 2024

Yeah I'm getting to them now, sorry about that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants