Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update highlights.scm for content_tag #300

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

NullVoxPopuli
Copy link
Contributor

@NullVoxPopuli NullVoxPopuli commented Feb 13, 2024

Updates the surrounding tokens for content-tag, <template> (the entirety of the contents here are passed to a sub-language, glimmer in this case in the screenshots)

Before:
image

After:
image

Info on content_tag:

Related: tree-sitter/tree-sitter-typescript#277

Checklist:

  • All tests pass in CI.
  • The script/parse-examples passes without issues.
  • There are sufficient tests for the new fix/feature.
  • Grammar rules have not been renamed unless absolutely necessary.
  • The conflicts section hasn't grown too much.
  • The parser size hasn't grown too much (check the value of STATE_COUNT in src/parser.c).

@NullVoxPopuli NullVoxPopuli changed the title Update highlights.scm for glimmer_x_tag Update highlights.scm for content_tag Feb 13, 2024
@NullVoxPopuli
Copy link
Contributor Author

rebased

@NullVoxPopuli
Copy link
Contributor Author

not sure how test failures could be related? 🤔

@NullVoxPopuli
Copy link
Contributor Author

rebased, and green!

@amaanq
Copy link
Member

amaanq commented Apr 18, 2024

note that this doesn't influence editor highlighting (unless your editor directly pulls these queries in)

@amaanq amaanq merged commit 3487795 into tree-sitter:master Apr 18, 2024
4 checks passed
@NullVoxPopuli NullVoxPopuli deleted the patch-1 branch April 20, 2024 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants